This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26308 )
Change subject: bitvec_read_field(): fix incorrect bit-shift issue found by UBSan
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c
File src/bitvec.c:
https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c@485
PS1, Line 485: if (len && bytenum_from_bitnum(*read_index + len - 1) >= bv->data_len) {
why this -1?
https://gerrit.osmocom.org/c/libosmocore/+/26308/1/src/bitvec.c@494
PS1, Line 494: int bit = bitvec_get_bit_pos((const struct bitvec *)bv, bv->cur_bit);
I'd rather still keep the error checking here.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26308
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4deeabba7ebb720cdbe7c85b37bc011d05bdfa65
Gerrit-Change-Number: 26308
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Nov 2021 11:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211117/7048ccc3/attachment.htm>