Change in libosmocore[master]: bitvec_read_field(): indicate errors using errno

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 17 11:01:18 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26307 )

Change subject: bitvec_read_field(): indicate errors using errno
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/26307/1/src/bitvec.c 
File src/bitvec.c:

https://gerrit.osmocom.org/c/libosmocore/+/26307/1/src/bitvec.c@479 
PS1, Line 479: uint64_t bitvec_read_field(struct bitvec *bv, unsigned int *read_index, unsigned int len)
I'm not really liking the idea of using errno in non libc code. I'd rather return (uint64_t)-1 in case of errnor, and document 0xfffffff(...)ff is returned in case of error.

If others still think using errno is fine, then I'm OK with it.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26307
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2cc734caa3365d03c2ae2b3f2cd9544933c25e9e
Gerrit-Change-Number: 26307
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Nov 2021 11:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211117/57fc6b19/attachment.htm>


More information about the gerrit-log mailing list