Change in osmo-ttcn3-hacks[master]: pcu: Drop mp_send_all_data_ind

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 17 10:37:00 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301 )

Change subject: pcu: Drop mp_send_all_data_ind
......................................................................

pcu: Drop mp_send_all_data_ind

osmo-pcu 1.0.0 was released, so we can drop references to older osmo-pcu
versions.

Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20
---
M pcu/PCUIF_Components.ttcn
1 file changed, 4 insertions(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pcu/PCUIF_Components.ttcn b/pcu/PCUIF_Components.ttcn
index 30982da..030da05 100644
--- a/pcu/PCUIF_Components.ttcn
+++ b/pcu/PCUIF_Components.ttcn
@@ -50,10 +50,6 @@
  *               +---------------------------+
  */
 
-modulepar {
-	boolean mp_send_all_data_ind := true;
-}
-
 /* Events are used by the components to indicate that something
  * has happened, e.g. we have got a connection from the PCU. */
 type enumerated RAW_PCU_EventType {
@@ -419,11 +415,9 @@
 				//log(prefix, "DATA.ind (len=0)");
 			}
 
-			if (use_msg or mp_send_all_data_ind) {
-				PCUIF.send(pcu_msg); /* Send to the PCU and notify the TC */
-				if (use_msg) {
-					TC.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_SENT, fn));
-				}
+			PCUIF.send(pcu_msg); /* Send to the PCU and notify the TC */
+			if (use_msg) {
+				TC.send(ts_RAW_PCU_CLCK_EV(TDMA_EV_PDTCH_BLOCK_SENT, fn));
 			}
 		}
 	}
@@ -513,9 +507,7 @@
 		});
 
 		const integer start_fn := 0;
-		if (mp_send_all_data_ind) {
-			f_tx_first_data_ind(bts_nr, info_ind, start_fn);
-		}
+		f_tx_first_data_ind(bts_nr, info_ind, start_fn);
 
 		/* Notify the test case that we're done with SI13 */
 		TC.send(ts_RAW_PCU_EV(BTS_EV_SI13_NEGO));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6720f066731b4336f8527643bed16ae7ea047c20
Gerrit-Change-Number: 26301
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211117/4d2040c6/attachment.htm>


More information about the gerrit-log mailing list