Change in pysim[master]: pySim-shell: add method to match card profile to card

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue Nov 16 10:25:54 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26165 )

Change subject: pySim-shell: add method to match card profile to card
......................................................................


Patch Set 5:

(2 comments)

Thanks for reviewing this. The feedback was there, but unfortunately not sent yet.

(Its probably because I forgot to click the send REPLY button. In any case this is very hard to operate, especially with multiple patches. All patches need a click on the REPLY button. Maybe that's just my imagination, but there was a time where comments were automatically posted along with the patches that were pushed. This even makes sense, the reply-comments are published along with the patch that is just pushed. It simply makes no sense to publish replays before handing in a new patch set.)

https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py 
File pySim/profile.py:

https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/profile.py@31 
PS3, Line 31: _
> Ok, then it's not that simple, I stand corrected. […]
Done


https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py 
File pySim/ts_51_011.py:

https://gerrit.osmocom.org/c/pysim/+/26165/3/pySim/ts_51_011.py@977 
PS3, Line 977: def _match_witch_card(scc:SimCardCommands) -> bool:
> sorry, but this argument doesn't hold up. […]
This makes sense - agreed.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26165
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If090d32551145f75c644657b90085a3ef5bfa691
Gerrit-Change-Number: 26165
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Nov 2021 10:25:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211116/115ad3bc/attachment.htm>


More information about the gerrit-log mailing list