Change in pysim[master]: ts_51_011: move _decode_select_response into profile class

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Nov 16 02:18:46 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26205 )

Change subject: ts_51_011: move _decode_select_response into profile class
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

All my comments are ideas for separate changes.

https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py 
File pySim/ts_51_011.py:

https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py@976 
PS2, Line 976: Any
More specific type of the returned value is 'object'.


https://gerrit.osmocom.org/c/pysim/+/26205/2/pySim/ts_51_011.py@976 
PS2, Line 976:     def decode_select_response(self, resp_hex:str) -> Any:
If self is not used, then it's a @staticmethod. We can mark it as such in a separate commit.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26205
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icf0143f64ca7d1c1ebf60ba06585f7afc1ac0d11
Gerrit-Change-Number: 26205
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 16 Nov 2021 02:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211116/5cf2186d/attachment.htm>


More information about the gerrit-log mailing list