Change in osmocom-bb[master]: logging: use meaningful default loglevels

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 15 17:12:22 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/16892 )

Change subject: logging: use meaningful default loglevels
......................................................................

logging: use meaningful default loglevels

Some logging categories use LOGL_INFO or even LOGL_DEBUG. Lets set those
to LOGL_NOTICE to have a less crowded default log output.

Change-Id: I3faefccae2218b17bd942bc2afac7d8e515897b7
Related: OS#2577
---
M src/host/layer23/src/common/logging.c
M src/host/virt_phy/src/logging.c
2 files changed, 20 insertions(+), 20 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/host/layer23/src/common/logging.c b/src/host/layer23/src/common/logging.c
index ed79991..636a615 100644
--- a/src/host/layer23/src/common/logging.c
+++ b/src/host/layer23/src/common/logging.c
@@ -36,7 +36,7 @@
 		.name = "DCS",
 		.description = "Cell selection",
 		.color = "\033[34m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DNB] = {
 		.name = "DNB",
@@ -48,54 +48,54 @@
 		.name = "DPLMN",
 		.description = "PLMN selection",
 		.color = "\033[32m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DRR] = {
 		.name = "DRR",
 		.description = "Radio Resource",
 		.color = "\033[1;34m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DMM] = {
 		.name = "DMM",
 		.description = "Mobility Management",
 		.color = "\033[1;32m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DCC] = {
 		.name = "DCC",
 		.description = "Call Control",
 		.color = "\033[1;33m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DSS] = {
 		.name = "DSS",
 		.description = "Supplenmentary Services",
 		.color = "\033[1;35m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DSMS] = {
 		.name = "DSMS",
 		.description = "Short Message Service",
 		.color = "\033[1;37m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DMNCC] = {
 		.name = "DMNCC",
 		.description = "Mobile Network Call Control",
 		.color = "\033[1;37m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DMEAS] = {
 		.name = "DMEAS",
 		.description = "MEasurement Reporting",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DPAG] = {
 		.name = "DPAG",
 		.description = "Paging",
 		.color = "\033[33m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DL1C]	= {
 		.name = "DL1C",
@@ -107,37 +107,37 @@
 		.name = "DSAP",
 		.description = "SAP Control",
 		.color = "\033[1;31m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DSUM] = {
 		.name = "DSUM",
 		.description = "Summary of Process",
 		.color = "\033[1;37m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DSIM] = {
 		.name = "DSIM",
 		.description = "SIM client",
 		.color = "\033[0;35m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DGPS] = {
 		.name = "DGPS",
 		.description = "GPS",
 		.color = "\033[1;35m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DMOB] = {
 		.name = "DMOB",
 		.description = "Mobile",
 		.color = "\033[1;35m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DPRIM] = {
 		.name = "DPRIM",
 		.description = "PRIM",
 		.color = "\033[1;32m",
-		.enabled = 1, .loglevel = LOGL_DEBUG,
+		.enabled = 1, .loglevel = LOGL_NOTICE,
 	},
 	[DLUA] = {
 		.name = "DLUA",
diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c
index 11a21a3..f898a08 100644
--- a/src/host/virt_phy/src/logging.c
+++ b/src/host/virt_phy/src/logging.c
@@ -70,28 +70,28 @@
 		.description = "Layer 1 Control",
 		.color = "\033[1;31m",
 		.enabled = 1,
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 	},
 	[DL1P] = {
 		.name = "DL1P",
 		.description = "Layer 1 Data",
 		.color = "\033[1;31m",
 		.enabled = 1,
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 	},
 	[DVIRPHY] = {
 		.name = "DVIRPHY",
 		.description = "Virtual Layer 1 Interface",
 		.color = "\033[1;31m",
 		.enabled = 1,
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 	},
 	[DMAIN] = {
 		.name = "DMAIN",
 		.description = "Main Program / Data Structures",
 		.color = "\033[1;32m",
 		.enabled = 1,
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 	},
 };
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/16892
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3faefccae2218b17bd942bc2afac7d8e515897b7
Gerrit-Change-Number: 16892
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211115/a9afa068/attachment.htm>


More information about the gerrit-log mailing list