This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26250 ) Change subject: tbf_dl_ass_fsm: Drop unsued X2000 timer callback ...................................................................... tbf_dl_ass_fsm: Drop unsued X2000 timer callback That timer is only relevant for transmission of Packet Access Reject, which happens only for Uplink assignment, and hence is only set in the timer of tbf_ul_ass_fsm, never in tbf_dl_ass_fsm. This is probably a copy-paste artifact when implementing both FSMs. Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b --- M src/tbf_dl_ass_fsm.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index 1d44c91..a5948e7 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -185,11 +185,7 @@ static int tbf_dl_ass_fsm_timer_cb(struct osmo_fsm_inst *fi) { - struct tbf_dl_ass_fsm_ctx *ctx = (struct tbf_dl_ass_fsm_ctx *)fi->priv; switch (fi->T) { - case -2000: - tbf_free(ctx->tbf); - break; default: OSMO_ASSERT(0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I95900e211eddb280c72fb712ba1da4d2230cb77b Gerrit-Change-Number: 26250 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211115/c02dcdd5/attachment.htm>