This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26187 ) Change subject: osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() ...................................................................... osmo_bsc_main: move generate_ma_for_bts() into bootstrap_bts() The function generate_ma_for_bts() is called when the OML TEI comes up. In the same code path boostrap_bts() is called as well. It would be more logical to call generate_ma_for_bts() from boostrap_bts() since it is also part of the bootstrapping process. Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Related: SYS#5369 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index ae9bd69..2436641 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -469,6 +469,10 @@ /* Initialize the BTS state */ gsm_bts_sm_mo_reset(bts->site_mgr); + + /* Generate Mobile Allocation bit-masks for all timeslots. + * This needs to be done here, because it's used for TS configuration. */ + generate_ma_for_bts(bts); } /* Callback function to be called every time we receive a signal from INPUT */ @@ -487,9 +491,6 @@ switch (signal) { case S_L_INP_TEI_UP: if (isd->link_type == E1INP_SIGN_OML) { - /* Generate Mobile Allocation bit-masks for all timeslots. - * This needs to be done here, because it's used for TS configuration. */ - generate_ma_for_bts(trx->bts); /* Check parameters and apply vty config dependent parameters */ rc = check_bts(trx->bts); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26187 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib2ed5b1eac3701cfb3a3e8dd478488ba5404d1fd Gerrit-Change-Number: 26187 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211115/43bc3fd9/attachment.htm>