Change in osmo-ttcn3-hacks[master]: pcu: Introduce as_ms_rx_ignore_empty helper

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Nov 12 20:04:17 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220 )

Change subject: pcu: Introduce as_ms_rx_ignore_empty helper
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220/1/pcu/GPRS_Components.ttcn@562 
PS1, Line 562: inout GprsMS ms
> In the event of multi-ts TBF, you want to schedule the next TS fore the MS in line 569. […]
My understanding is that here we send RTS.req exactly for the same timeslot as indicated in the received DATA.req. The timeslot number is determined by TsTrxBtsNum, not GprsMS. If we start sending RTS.req with different timeslot numbers from here, or even for multiple timeslots, then it's a mess. If we ever want to make this altstep handle several timeslots, then one can change it to accept a receive TsTrxBtsNum template, which would match several TRX/TS values.

In the end, you can always introduce GprsMS parameter when you actually start using it. Having it now is meaningless and confusing.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26220
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3c80ba4b8d229fa4a75dfd04abb7c5aae26e221c
Gerrit-Change-Number: 26220
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Nov 2021 20:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211112/2407a665/attachment.htm>


More information about the gerrit-log mailing list