Change in osmo-msc[master]: Do not mention deprecated -l / --database options

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Nov 12 17:29:00 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/26225 )


Change subject: Do not mention deprecated -l / --database options
......................................................................

Do not mention deprecated -l / --database options

Change-Id: I47fe7e64126710db34c49f48ea9e8f8d46662e4b
---
M doc/manuals/chapters/running.adoc
M src/osmo-msc/msc_main.c
2 files changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/25/26225/1

diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc
index 988b84d..8665395 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -5,7 +5,7 @@
 
 === SYNOPSIS
 
-*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL'] [-l 'DATABASE']
+*osmo-msc* [-h|-V] [-d 'DBGMASK'] [-D] [-c 'CONFIGFILE'] [-s] [-T] [-e 'LOGLEVEL']
 
 === OPTIONS
 
@@ -35,8 +35,6 @@
 	Set the global log level for logging to stderr. This has mostly
 	been deprecated by VTY based logging configuration, see
 	<<logging>> for more information.
-*-l, --database 'DATABASE'*::
-	Specify the file name of the SQLite3 database to use as SMS storage
 
 
 === Multiple instances
diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c
index 07d76dd..9657c71 100644
--- a/src/osmo-msc/msc_main.c
+++ b/src/osmo-msc/msc_main.c
@@ -127,7 +127,6 @@
 	printf("  -D --daemonize             Fork the process into a background daemon.\n");
 	printf("  -c --config-file filename  The config file to use.\n");
 	printf("  -s --disable-color\n");
-	printf("  -l --database db-name      The database to use.\n");
 	printf("  -T --timestamp             Prefix every log line with a timestamp.\n");
 	printf("  -V --version               Print the version of OsmoMSC.\n");
 	printf("  -e --log-level number      Set a global loglevel.\n");
@@ -173,7 +172,7 @@
 			{"daemonize", 0, 0, 'D'},
 			{"config-file", 1, 0, 'c'},
 			{"disable-color", 0, 0, 's'},
-			{"database", 1, 0, 'l'},
+			{"database", 1, 0, 'l'}, /* deprecated */
 			{"timestamp", 0, 0, 'T'},
 			{"version", 0, 0, 'V' },
 			{"log-level", 1, 0, 'e'},
@@ -208,6 +207,8 @@
 			break;
 		case 'l':
 			msc_cmdline_config.database_name = optarg;
+			fprintf(stderr, "Command line argument '-%c' is deprecated, use VTY "
+				"parameter 'msc' / 'sms-database %s' instead.\n", c, optarg);
 			break;
 		case 'c':
 			msc_cmdline_config.config_file = optarg;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/26225
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I47fe7e64126710db34c49f48ea9e8f8d46662e4b
Gerrit-Change-Number: 26225
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211112/4a3c991f/attachment.htm>


More information about the gerrit-log mailing list