This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26215 ) Change subject: pcu_main: Mark -r cmdline param as deprecated ...................................................................... pcu_main: Mark -r cmdline param as deprecated We have VTY support for it enabled in osmo-pcu since a while ago. Let's mark it as depcreated now so that we can drop this cmdline arg in the future. Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f --- M doc/manuals/chapters/running.adoc M src/pcu_main.cpp 2 files changed, 2 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 5daecf8..78f79b6 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -21,12 +21,6 @@ Specify the file and path name of the configuration file to be used. If none is specified, use `osmo-pcu.cfg` in the current working directory. -*-r, --realtime 'PRIO'*:: - Enable use of the Linux kernel realtime priority scheduler with - the specified priority. - It is recommended you use this option on low-performance - embedded systems or systems that encounter high non-GSM/GPRS - load. *-m, --mcc 'MCC'*:: Use the given MCC instead of that provided by BTS via PCU socket *-n, --mnc 'MNC'*:: diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index 003cabb..7992853 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -74,7 +74,6 @@ " -m --mcc MCC Use given MCC instead of value provided by BTS\n" " -n --mnc MNC Use given MNC instead of value provided by BTS\n" " -V --version Print version\n" - " -r --realtime PRIO Use SCHED_RR with the specified priority\n" " -D --daemonize Fork the process into a background daemon\n" " -i --gsmtap-ip The destination IP used for GSMTAP\n" "\nVTY reference generation:\n" @@ -165,6 +164,8 @@ break; case 'r': rt_prio = atoi(optarg); + fprintf(stderr, "Command line argument '-r' is deprecated, use VTY " + "cpu-sched node setting 'policy rr %d' instead.\n", rt_prio); break; case 'D': daemonize = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic39c94984cb311aac0464d69f564af6d5447bd0f Gerrit-Change-Number: 26215 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211112/06bbe89c/attachment.htm>