Change in libusrp[master]: migrate to python3

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Nov 12 10:48:53 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/19675 )

Change subject: migrate to python3
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libusrp/+/19675/2/firmware/src/common/build_eeprom.py 
File firmware/src/common/build_eeprom.py:

https://gerrit.osmocom.org/c/libusrp/+/19675/2/firmware/src/common/build_eeprom.py@87 
PS2, Line 87: key=lambda a: a.addr
> Not sure if this change is correct.
looks correct according to https://stackoverflow.com/a/403426

also I've verified that the generated files are the same in both versions.

  $ git checkout master
  $ autoreconf -fi
  $ ./configure
  $ make
  $ cp firmware/src/usrp2/burn-usrp* /tmp/
  $ make distclean
  $ git review -d 19675
  $ autoreconf -fi
  $ ./configure
  $ make
  $ diff -s /tmp/burn-usrp2-eeprom firmware/src/usrp2/burn-usrp2-eeprom
  Files /tmp/burn-usrp2-eeprom and firmware/src/usrp2/burn-usrp2-eeprom are identical
  $ diff -s /tmp/burn-usrp4-eeprom firmware/src/usrp2/burn-usrp4-eeprom
  Files /tmp/burn-usrp4-eeprom and firmware/src/usrp2/burn-usrp4-eeprom are identical



-- 
To view, visit https://gerrit.osmocom.org/c/libusrp/+/19675
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libusrp
Gerrit-Branch: master
Gerrit-Change-Id: Ib1604b36c32630e1360e06567cbd5f63a78df547
Gerrit-Change-Number: 19675
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: roox <mardnh at gmx.de>
Gerrit-Comment-Date: Fri, 12 Nov 2021 10:48:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211112/022e62bf/attachment.htm>


More information about the gerrit-log mailing list