This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26208 ) Change subject: tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent ...................................................................... tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent If by the time the PktDlAss is to be scheduled by the scheduler the DL TBF is gone, the FSM will abort the assignment and go back to state NONE. However, the transition was missing, ending up in the scheduler trying to schedule the message unsuccessfuly lots of times per second, clogging the logs and disrupting normal operation. Related: OS#5293 Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 --- M src/tbf_dl_ass_fsm.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/08/26208/1 diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index b7b3d88..18db659 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -208,7 +208,9 @@ }, [TBF_DL_ASS_SEND_ASS] = { .in_event_mask = X(TBF_DL_ASS_EV_CREATE_RLCMAC_MSG), - .out_state_mask = X(TBF_DL_ASS_WAIT_ACK), + .out_state_mask = + X(TBF_DL_ASS_WAIT_ACK) | + X(TBF_DL_ASS_NONE), .name = "SEND_ASS", .action = st_send_ass, }, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 Gerrit-Change-Number: 26208 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211111/4187df22/attachment.htm>