Change in osmo-pcu[master]: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for n...

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26207 )


Change subject: tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one
......................................................................

tbf_dl_ass_fsm: Log both TBFs if old TBF is handling assignment for new one

Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9
---
M src/tbf_dl_ass_fsm.c
1 file changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/07/26207/1

diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c
index 37ced61..b7b3d88 100644
--- a/src/tbf_dl_ass_fsm.c
+++ b/src/tbf_dl_ass_fsm.c
@@ -77,9 +77,6 @@
 		return NULL;
 	}
 
-	if (new_dl_tbf == as_dl_tbf(ctx->tbf))
-		LOGPTBF(ctx->tbf, LOGL_DEBUG, "New and old TBF are the same.\n");
-
 	if (old_tfi_is_valid && ms_tlli(ms) == GSM_RESERVED_TMSI) {
 		LOGPTBF(ctx->tbf, LOGL_ERROR,
 			  "The old TFI is not assigned and there is no TLLI. New TBF %s\n",
@@ -99,7 +96,12 @@
 	};
 	bitvec_unhex(&bv, DUMMY_VEC);
 
-	LOGPTBF((struct gprs_rlcmac_tbf *)new_dl_tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n");
+	if (ctx->tbf != (struct gprs_rlcmac_tbf *)new_tbf)
+		LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH) for %s\n",
+			  tbf_name((const struct gprs_rlcmac_tbf *)new_tbf));
+	else
+		LOGPTBFDL(ctx->tbf, LOGL_INFO, "start Packet Downlink Assignment (PACCH)\n");
+
 	mac_control_block = (RlcMacDownlink_t *)talloc_zero(ctx->tbf, RlcMacDownlink_t);
 	write_packet_downlink_assignment(mac_control_block, old_tfi_is_valid,
 		tbf_tfi(ctx->tbf), (tbf_direction(ctx->tbf) == GPRS_RLCMAC_DL_TBF),

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26207
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I4ec4eb2ca3f4fa576a4f9ada8c2462f59ca078b9
Gerrit-Change-Number: 26207
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211111/89f15eb2/attachment.htm>