Change in pysim[master]: pySim-shell: guess number of records when not specified

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 11 08:37:39 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26204 )

Change subject: pySim-shell: guess number of records when not specified
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG@7 
PS1, Line 7: pySim-shell: guess number of records when not specified
I guess the message should state this is only related to the "export" command and not some general problem.


https://gerrit.osmocom.org/c/pysim/+/26204/1//COMMIT_MSG@13 
PS1, Line 13: u
This is flawed:
* a record containing 0xfffff... is an existing record, and not the end of the file
* it is perfectly legal to have records filled with ffff e.g. at position 5 and then records filled with valid data in records 6...25.  This is what happens if you delete phone book entries or SMS from a card.
* end of the file can implicitly only be  detected by reading the first invalid record, which will return with a related status word.  You then know the last valid record number is one lower than the first failing one.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/26204
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib480797d881b9ec607ec6a86b73d452449f8cf87
Gerrit-Change-Number: 26204
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 11 Nov 2021 08:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211111/7159372a/attachment.htm>


More information about the gerrit-log mailing list