This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26199 ) Change subject: ns2: Avoid use-after-free when SGSN-side non-persistent SNS-NSE fails ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2.c@1398 PS1, Line 1398: rc = ns2_sns_notify_alive(nse, nsvc, unblocked); > What about trying to retrieve again the nse from the nsvc (nvsc->nse) and checking if it's null? or […] Good idea, I'll just try to get it from the nsi again. https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/26199/1/src/gb/gprs_ns2_sns.c@2587 PS1, Line 2587: int ns2_sns_notify_alive(struct gprs_ns2_nse *nse, struct gprs_ns2_vc *nsvc, bool alive) > Please document the behavior of the function somewhere: "-ENONENT if NSE is freed" or alike. I'll leave the function be instead -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0486a77fd3e21fd3904bd19e4e0225ffbf654935 Gerrit-Change-Number: 26199 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 10 Nov 2021 16:48:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: daniel <dwillmann at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211110/97a84e91/attachment.htm>