Change in osmo-pcu[master]: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26198 )


Change subject: pdch: Drop previous UL TBF from MS who sent PktResReq through SBA
......................................................................

pdch: Drop previous UL TBF from MS who sent PktResReq through SBA

If the MS has a pending UL TBF but we just received a PktResReq on an
allocated SBA from it (same TLLI, hence same MS), then it means it
allocated the SBA through RACH req and hence it was on CCCH. That means
it was not active on any PDCH, hence for sure the previous UL TBF can be
dropped.

Related: OS#5293

Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c
---
M src/pdch.cpp
1 file changed, 10 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/98/26198/1

diff --git a/src/pdch.cpp b/src/pdch.cpp
index 4d82ab1..c48b078 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -680,6 +680,16 @@
 				"MS requests UL TBF throguh SBA\n", fn);
 			ms_set_ta(ms, sba->ta);
 			sba_free(sba);
+			/* If MS identified by TLLI sent us a PktResReq through SBA, it means it came
+			 * from CCCH, so it's for sure not using previous UL
+			 * TBF; drop it if it still exits on our end: */
+			if ((ul_tbf = ms_ul_tbf(ms))) {
+				/* Get rid of previous finished UL TBF before providing a new one */
+				LOGPTBFUL(ul_tbf, LOGL_NOTICE,
+					  "Got PACKET RESOURCE REQ while TBF not finished, killing pending UL TBF\n");
+				tbf_free(ul_tbf);
+				ul_tbf = NULL;
+			}
 			/* MS seized the PDCH answering on the SBA: */
 			bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS);
 			break;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26198
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1f20dba56f46ea15cbb9b03bdc5b79d923491a3c
Gerrit-Change-Number: 26198
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211110/e7058d2e/attachment.htm>