Change in osmo-pcu[master]: pdch: Log line detaching TBF at start of the function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Nov 10 14:51:59 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26176 )

Change subject: pdch: Log line detaching TBF at start of the function
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/26176/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/26176/1/src/pdch.cpp@1138 
PS1, Line 1138: %d TBFs, "
              : 		"USFs = %02x, TFIs = %08x
> it's the current state, it's fine keeping it this way imho, it lets you know what detach is going to […]
It says "Detaching", so I also would expect the current state.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26176
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6811d3772e2ac850741d3db5ec32be5c0812e81a
Gerrit-Change-Number: 26176
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Nov 2021 14:51:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211110/2f5bebe2/attachment.htm>


More information about the gerrit-log mailing list