Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 10 13:20:25 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 )

Change subject: rework the counters and stats so they work with the threaded mgw
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c 
File src/libosmo-mgcp/mgcp_threads.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/26190/5/src/libosmo-mgcp/mgcp_threads.c@498 
PS5, Line 498: 	usleep(1000 * 100);
Let's rather have some volatile integer per thread or alike to check this, with a static bool done = true when it holds true. Maybe simply a global static counter which is incremented every time a thread is ready.

 You can incorporate that into rate_ctr_timer_cb and keep checking every second or even less in this case.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0
Gerrit-Change-Number: 26190
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Nov 2021 13:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211110/b837c4af/attachment.htm>


More information about the gerrit-log mailing list