Change in osmo-mgw[master]: rework message handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 10 12:33:42 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26189 )

Change subject: rework message handling
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/26189/2/src/libosmo-mgcp/mgcp_protocol.c@425 
PS2, Line 425: 	for (int i = 0; i < ARRAY_SIZE(mgcp_requests); i++) {
> I don't think we usually define int inside the loop in C files.
BTW, ths patch is changing the place where i is declared for no good reason I can tell, so even more reason to leave it as it was ad simplify the patch.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26189
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I8cbbe5936067ea1caa7935e8d14908ac5c4010bd
Gerrit-Change-Number: 26189
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Nov 2021 12:33:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211110/7fcf665d/attachment.htm>


More information about the gerrit-log mailing list