Change in osmo-bsc[master]: add time_cc API: cumlative counter for time, reported as rate_ctr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Nov 9 14:04:09 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 )

Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

Nice api and well documented, LGTM

https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h 
File include/osmocom/bsc/time_cc.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h@1 
PS6, Line 1: /* Report the cumulative counter of time for which a flag is true as rate counter. */
Missing license header


https://gerrit.osmocom.org/c/osmo-bsc/+/25973/6/include/osmocom/bsc/time_cc.h@37 
PS6, Line 37:  * - If gran_usec is set to one second and forget_sum_usec is set to one minute, the reported rate counter has a possible
(This goes over 120 characters, so it wraps here in gerrit review for me. I think longer text comments are easier to read at less characters per line, so usually I ":set colorcolumn=80" for those.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310
Gerrit-Change-Number: 25973
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Nov 2021 14:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/0c18955d/attachment.htm>


More information about the gerrit-log mailing list