This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26177 ) Change subject: pdch: Log TS enable/disable transitions ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26177/1/src/pdch.cpp File src/pdch.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26177/1/src/pdch.cpp@147 PS1, Line 147: OSMO_ASSERT > Unrelated to this patch, but do we really want to assert() here? […] We want to assert here for sure. But using _is_enabled is informative for regular use for user when looking at logs, as well as it's really informative when this assert is hit, since last message is "enabled => enabled". -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6780634de4791382ccd25bf7b74f5286420e2c52 Gerrit-Change-Number: 26177 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 09 Nov 2021 14:00:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/379e30a6/attachment.htm>