Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: remove misleading PADDING attributes

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109 )

Change subject: library/GSM_RR_Types: remove misleading PADDING attributes
......................................................................

library/GSM_RR_Types: remove misleading PADDING attributes

Unfortunately, TITAN has a weird (and often unusable) model of
defining padding in records.  According to its reference guide,
padding length is counted from the beginning of the message.
So if the 'MeasurementResults' is a part of another record, and
there are other fields preceeding it, the encoded representation
of the 'MeasurementResults' may still be shorter than 16 octets.

Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2
---
M library/GSM_RR_Types.ttcn
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index f7b00e1..f45784c 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -650,8 +650,7 @@
 		NcellReports	ncell_reports optional
 	} with { variant (no_ncell_m) "LENGTHTO(ncell_reports)"
 		 variant (no_ncell_m) "UNIT(elements)"
-		 variant "PADDING(yes)"
-		 variant "FIELDLENGTH(16)"
+		 /* FIXME: pad to 16 octets */
 	};
 
 	type record NcellReport {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26109
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia1c87ae85ee402369dad0dfd81159f179095c8d2
Gerrit-Change-Number: 26109
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/f69641c3/attachment.htm>