Change in osmo-pcu[master]: pdch: Log TS enable/disable transitions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Nov 9 12:40:27 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26177 )

Change subject: pdch: Log TS enable/disable transitions
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/26177/1/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/26177/1/src/pdch.cpp@147 
PS1, Line 147: OSMO_ASSERT
Unrelated to this patch, but do we really want to assert() here?
Wouldn't it be sufficient to log an error and return early?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26177
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6780634de4791382ccd25bf7b74f5286420e2c52
Gerrit-Change-Number: 26177
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Nov 2021 12:40:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/39c4ad92/attachment.htm>


More information about the gerrit-log mailing list