Change in libosmocore[master]: stats: clarify error messages in cfg_no_stats_reporter_{statsd, log}

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 )

Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log}
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

I would not avoid printing the empty string name, that provides information on which one is not found. Printing that conditionally is confusing imho.

https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c 
File src/vty/stats_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c@316 
PS1, Line 316: name
> Hmm. I wonder if "" is not so good, but it is even possible that name can be null. […]
If user write no NAME arg, then argc=0 and name used internally in osmo_stats_reporter_find is NULL. Since user cannot add a name with empty string (""), then adding no name is the same as using empty string, and it's handled internally by passing NULL.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04
Gerrit-Change-Number: 26175
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Nov 2021 11:50:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/96a5b0ea/attachment.htm>