This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26175 )
Change subject: stats: clarify error messages in cfg_no_stats_reporter_{statsd,log}
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c
File src/vty/stats_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/26175/1/src/vty/stats_vty.c@316
PS1, Line 316: name
> And yes, name can be NULL here. This is fine.
No, that will probably print "(null)", which is not the same as if the user called the reporter "(null)" himself, so that's confusing. I'd actually print "" here if the name is NULL.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26175
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I287130213c7de31a510f293bed0f3daddd53ce04
Gerrit-Change-Number: 26175
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Nov 2021 11:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/81f89947/attachment.htm>