Change in osmo-ci[master]: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Nov 9 10:48:22 UTC 2021


Hello Jenkins Builder, neels, fixeria, pespin, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-ci/+/26172

to look at the new patch set (#2).

Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS
......................................................................

lint: checkpatch_osmo: ignore TRAILING_STATEMENTS

In Osmocom code, we have the following written in one line:
  while (osmo_select_main_ctx(1) > 0);

This currently causes the following linter error:
  ERROR:TRAILING_STATEMENTS: trailing statements should be on next line

According to the linter, we should write it as follows:
  while (osmo_select_main_ctx(1) > 0)
  	;

But this is not followed in Osmocom code, so let's ignore the check.

Related: OS#5087
Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/72/26172/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279
Gerrit-Change-Number: 26172
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/2592aecb/attachment.htm>


More information about the gerrit-log mailing list