Change in osmo-ttcn3-hacks[master]: pcu: Improve counter validation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 8 18:35:26 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130 )

Change subject: pcu: Improve counter validation
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

looks like a lot of boilerplte code to me which could be improved by use of templates.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130/2/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130/2/pcu/PCU_Tests.ttcn@3946 
PS2, Line 3946: name := "TTCN3.bts.0.rach.requests", mtype := "c", min := num_req, max := num_req
might be worth to ahave some kind of template for filling in this struct?  the template cound default min/max to 0, and mtype to 'c', making this code much more compact.  The valueof() could happen in f_statsd_expect(valueof(expect)); or even pushed into f_statsd_expect if the latter would accept a template argument.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/26130
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I98e340053c91abdbf28c6e9641190bc78df35eff
Gerrit-Change-Number: 26130
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Nov 2021 18:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/37ef7e86/attachment.htm>


More information about the gerrit-log mailing list