Change in osmo-pcu[master]: tbf_ul: Improve documentation of tbf_alloc_ul_pacch()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26079 )

Change subject: tbf_ul: Improve documentation of tbf_alloc_ul_pacch()
......................................................................

tbf_ul: Improve documentation of tbf_alloc_ul_pacch()

Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d
---
M src/tbf_ul.cpp
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp
index f0d16b5..9390fbb 100644
--- a/src/tbf_ul.cpp
+++ b/src/tbf_ul.cpp
@@ -151,7 +151,12 @@
 	return tbf;
 }
 
-/* Alloc a UL TBF to be assigned over PACCH */
+/* Alloc a UL TBF to be assigned over PACCH. Called when an MS requests to
+ * create a new UL TBF during the end of life of a previous UL TBF (or an SBA).
+ * In summary, this TBF is allocated as a consequence of receiving a "Pkt
+ * Resource Req" or "Pkt Ctrl Ack" from the MS.
+ * See TS 44.060 9.3.2.4.2 "Non-extended uplink TBF mode".
+ */
 gprs_rlcmac_ul_tbf *tbf_alloc_ul_pacch(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx)
 {
 	struct gprs_rlcmac_ul_tbf *tbf;
@@ -162,6 +167,7 @@
 		/* Caller will most probably send a Imm Ass Reject after return */
 		return NULL;
 	}
+	/* Contention resolution is considered to be done since TLLI is known in MS: */
 	tbf->m_contention_resolution_done = 1;
 	osmo_fsm_inst_dispatch(tbf->state_fsm.fi, TBF_EV_ASSIGN_ADD_PACCH, NULL);
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26079
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d
Gerrit-Change-Number: 26079
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/bfb20926/attachment.htm>