Change in osmo-pcu[master]: bts_pch_timer: Fix timer working only for MI type IMSI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Nov 8 18:31:00 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26166 )

Change subject: bts_pch_timer: Fix timer working only for MI type IMSI
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c 
File src/bts_pch_timer.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c@37 
PS2, Line 37: p->ptmsi != GSM_RESERVED_TMSI
Above you already ensure that ptmsi != GSM_RESERVED_TMSI, so this check is redundant.


https://gerrit.osmocom.org/c/osmo-pcu/+/26166/2/src/bts_pch_timer.c@87 
PS2, Line 87: 	osmo_strlcpy(p->imsi, imsi, sizeof(p->imsi));
OSMO_STRLCPY_ARRAY(p->imsi, imsi);



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26166
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iedffb7c6978a3faf0fc26ce2181dde9791a8b6f4
Gerrit-Change-Number: 26166
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Nov 2021 18:31:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/d0f236af/attachment.htm>


More information about the gerrit-log mailing list