Change in osmo-pcu[master]: pdch::rcv_resource_request(): Use local var to store bts pointer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 8 16:29:51 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 )

Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/26078/4/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/26078/4/src/pdch.cpp@616 
PS4, Line 616: 	struct gprs_rlcmac_bts *bts = trx->bts;
> why not call bts() here though? […]
It's already in the direction of getting rid of C++ getters, so that let's less churn to get rid of in the future.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61
Gerrit-Change-Number: 26078
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Nov 2021 16:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/7157eaf5/attachment.htm>


More information about the gerrit-log mailing list