Change in osmo-pcu[master]: Add counter for successful contention resolution procedures

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 )

Change subject: Add counter for successful contention resolution procedures
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/bts.cpp@150 
PS4, Line 150: 	{ "immediate:assignment_ul:contention_resolution_success", "First RLC Block (PDU) on the PDTCH from the MS received"}, /* TS 52.402 B.2.1.51 */
(kind of long name, in bts we usually have "imm ass"-like abbreviations -- can't change that part here, but maybe "cont_res_succ", and write "Contention resolution success" in the description? Personally I am actually for writing things out long, but trying to adhere to osmo style)


https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/pdch.cpp 
File src/pdch.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/26080/4/src/pdch.cpp@654 
PS4, Line 654: 			bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS);
(also here)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c
Gerrit-Change-Number: 26080
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Nov 2021 16:18:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/632fa2df/attachment.htm>