Change in osmo-bts[master]: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Nov 8 15:37:56 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25734 )

Change subject: gsm_lchan_interf_meas_calc_avg(): adapt to the ordering of boundaries
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c 
File src/common/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c@602 
PS5, Line 602: ) p
usually no space after type cast


https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c@605 
PS5, Line 605: 				bts->interference.band_map[i] = 6 - i;
i'm a bit confused by '5 - i' vs '6 - i'


https://gerrit.osmocom.org/c/osmo-bts/+/25734/5/src/common/oml.c@608 
PS5, Line 608: 				bts->interference.band_map[i] = i;
...especially because there is no diff-by-one involved here



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25734
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I88d841d8d835bde8392c7b606b28c9070b7adc6e
Gerrit-Change-Number: 25734
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Nov 2021 15:37:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/b8b4dc24/attachment.htm>


More information about the gerrit-log mailing list