This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26158 ) Change subject: tbf_ul: Update FSM names for dummy reject TBFs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26158/1/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/26158/1/src/tbf.cpp@737 PS1, Line 737: int8_t tfi = tbf_tfi(tbf) == TBF_TS_UNSET ? -1 : tbf_tfi(tbf); i'd prefer aggressive bracing in compounded statements like this. more often than not, these do unexpected stuff because of omitted braces. at least for (y == z), to make sure it isn't interpreted as x = (y == (z ? 1 : 2)) Bugs like this are quite hard to find, seen it happen. or even x = ((y == z) ? 1 : 2) (also makes it easier to read IMHO.) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I73a197795a9c8e9cd8dc06bf46ddb8f275d2c289 Gerrit-Change-Number: 26158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 08 Nov 2021 15:31:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/21d7daac/attachment.htm>