This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26078 ) Change subject: pdch::rcv_resource_request(): Use local var to store bts pointer ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/26078/1//COMMIT_MSG@7 PS1, Line 7: pdch::rcv_resource_request(): Use local var to store bts pointer > I think it's obvious that dereferencing the pointer once is better than doing it several times by ca […] Well, it is obvious *for you*. For me it was not, especially given that you still have code like trx_no() and ul_tbf->ms() in this function. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ica727c4b70cecc0ddb5d2a235bfc416735754b61 Gerrit-Change-Number: 26078 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Mon, 08 Nov 2021 13:26:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/0bee3df6/attachment.htm>