Change in osmo-bsc[master]: ipaccess-config: improve readability of printed attribute response

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Nov 8 13:16:17 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26149 )

Change subject: ipaccess-config: improve readability of printed attribute response
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> IMHO That should at least be a cmdline option, some programs may rely on one-entry-per-line format (we need to check OGT). Something like --enable-pretty-printing-json.

This is still valid JSON, isn't it? Whitespace does not matter in JSON. The only thing I am worried about is the trailing comma, but some parsers do permit it. I guess you're using some parser in OGT rather than parsing the output manually?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If99ec89081af4ebd65152fc0a31ebdec491f3876
Gerrit-Change-Number: 26149
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Nov 2021 13:16:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/d0160c30/attachment.htm>


More information about the gerrit-log mailing list