Change in osmo-pcu[master]: bts: Count RACH Request with unexpected content

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 8 12:23:32 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26076 )

Change subject: bts: Count RACH Request with unexpected content
......................................................................

bts: Count RACH Request with unexpected content

Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b
---
M src/bts.cpp
M src/bts.h
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/bts.cpp b/src/bts.cpp
index ee4da01..6ef3280 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -139,6 +139,7 @@
 	{ "rach:requests:11bit",	"11BIT_RACH requests received"},
 	{ "rach:requests:one_phase",	"One phase packet access with request for single TS UL"}, /* TS 52.402 B.2.1.49 */
 	{ "rach:requests:two_phase",	"Single block packet request for two phase packet access"}, /* TS 52.402 B.2.1.49 */
+	{ "rach:requests:unexpected",	"RACH Request with unexpected content received"},
 	{ "spb:uplink_first_segment",   "First seg of UL SPB  "},
 	{ "spb:uplink_second_segment",  "Second seg of UL SPB "},
 	{ "spb:downlink_first_segment", "First seg of DL SPB  "},
@@ -896,8 +897,11 @@
 
 	/* Parse [EGPRS Packet] Channel Request from RACH.ind */
 	rc = parse_rach_ind(rip, &chan_req);
-	if (rc) /* Send RR Immediate Assignment Reject */
+	if (rc) {
+		bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_UNEXPECTED);
+		/* Send RR Immediate Assignment Reject */
 		goto send_imm_ass_rej;
+	}
 
 	if (chan_req.single_block) {
 		bts_do_rate_ctr_inc(bts, CTR_RACH_REQUESTS_TWO_PHASE);
diff --git a/src/bts.h b/src/bts.h
index 06eb07c..fa3216f 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -131,6 +131,7 @@
 	CTR_RACH_REQUESTS_11BIT,
 	CTR_RACH_REQUESTS_ONE_PHASE,
 	CTR_RACH_REQUESTS_TWO_PHASE,
+	CTR_RACH_REQUESTS_UNEXPECTED,
 	CTR_SPB_UL_FIRST_SEGMENT,
 	CTR_SPB_UL_SECOND_SEGMENT,
 	CTR_SPB_DL_FIRST_SEGMENT,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I86420b08a9a634ca2e1f5a1c7e66ec3d3c08ce0b
Gerrit-Change-Number: 26076
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/3772e9d7/attachment.htm>


More information about the gerrit-log mailing list