Change in osmo-pcu[master]: vty: Log tbf_state when showing a TBF

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 8 12:22:45 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26131 )

Change subject: vty: Log tbf_state when showing a TBF
......................................................................

vty: Log tbf_state when showing a TBF

That's one of the most important information bits about a TBF when
debugging, and it's not shown currently, only when "show ms" is used.

Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945
---
M src/pcu_vty_functions.cpp
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp
index 21851df..fb7897d 100644
--- a/src/pcu_vty_functions.cpp
+++ b/src/pcu_vty_functions.cpp
@@ -54,8 +54,9 @@
 		tbf->ta(),
 		tbf->direction == GPRS_RLCMAC_UL_TBF ? "UL" : "DL",
 		tbf->imsi(), VTY_NEWLINE);
-	vty_out(vty, " created=%lu state=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s",
-		tbf->created_ts(), tbf->state_fsm.state_flags,
+	vty_out(vty, " created=%lu state=%s flags=%08x [CCCH:%u, PACCH:%u] 1st_TS=%d 1st_cTS=%d ctrl_TS=%d MS_CLASS=%d/%d%s",
+		tbf->created_ts(), tbf->state_name(),
+		tbf->state_fsm.state_flags,
 		tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_CCCH),
 		tbf->state_fsm.state_flags & (1 << GPRS_RLCMAC_FLAG_PACCH),
 		tbf->first_ts,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26131
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I98e3c9cac4ca6fc29695768ecc6e0444e618b945
Gerrit-Change-Number: 26131
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/f9a30bc6/attachment.htm>


More information about the gerrit-log mailing list