Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Nov 6 00:54:33 UTC 2021


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949 )

Change subject: BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment()
......................................................................

BSC_Tests: fix DTE in TC_lost_sdcch_during_assignment()

This test case fails in ttcn3-bsc-test-sccplite due to:

  BSC_Tests.ttcn:10212 Dynamic test case error:
    Using the value of an optional field containing omit.

Change-Id: I235027c2b53b8f2ae975e25eb7c38b1959668d6f
Related: SYS#5627
---
M bsc/BSC_Tests.ttcn
1 file changed, 3 insertions(+), 6 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index ad8f666..f602929 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -10311,11 +10311,9 @@
  * Activ Ack (SYS#5627). */
 private function f_TC_lost_sdcch_during_assignment(charstring id) runs on MSC_ConnHdlr {
 	var PDU_BSSAP ass_cmd := f_gen_ass_req();
-	if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_AoIP) {
-		ass_cmd.pdu.bssmap.assignmentRequest.codecList := g_pars.ass_codec_list;
-	}
-	ass_cmd.pdu.bssmap.assignmentRequest.channelType :=
-				f_BSSMAP_chtype_from_codec(g_pars.ass_codec_list.codecElements[0]);
+
+	ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType);
+	ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));
 
 	var BSSMAP_FIELD_CodecType codecType;
 	codecType := valueof(ass_cmd.pdu.bssmap.assignmentRequest.codecList.codecElements[0].codecType);
@@ -10389,7 +10387,6 @@
 	f_init(1, true);
 	f_sleep(1.0);
 
-	pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR}));
 	vc_conn := f_start_handler(refers(f_TC_lost_sdcch_during_assignment), pars);
 	vc_conn.done;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/25949
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I235027c2b53b8f2ae975e25eb7c38b1959668d6f
Gerrit-Change-Number: 25949
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211106/71677427/attachment.htm>


More information about the gerrit-log mailing list