Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Fri Nov 5 09:18:55 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 )

Change subject: Make UTRAN encryption algorithms configurable
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c 
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c@371 
PS4, Line 371: 	for (i = 0; i < 8; i++) {
> is it a problem? so far we never set it to anything > UEA2 because the vty validates the range and t […]
Ack


https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/tests/msc_vlr/msc_vlr_test_umts_authen.c 
File tests/msc_vlr/msc_vlr_test_umts_authen.c:

https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/tests/msc_vlr/msc_vlr_test_umts_authen.c@344 
PS4, Line 344: 	net->uea_encryption_mask = 0x06;
I find those magic numbers a bit hard to read.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd
Gerrit-Change-Number: 22766
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Nov 2021 09:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211105/0fe18e2e/attachment.htm>


More information about the gerrit-log mailing list