Change in osmo-bsc[master]: rsl_tx_chan_activ(): fix manual channel activation for nanoBTS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Nov 4 22:59:40 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26119 )


Change subject: rsl_tx_chan_activ(): fix manual channel activation for nanoBTS
......................................................................

rsl_tx_chan_activ(): fix manual channel activation for nanoBTS

nanoBTS would NACK a CHANnel ACTIVation message for an 'intra cell
channel change' if it does not contain the Timing Advance IE.  And
this is right, because according to 3GPP TS 48.058, section 8.4.1,
point '4)', it *must* be included.

Indeed, the actual Timing Advance value is not known during the
manual channel activation triggered from the VTY interface.  So
let's merely indicate 0 if it's not known.

Change-Id: Iee7ddb4cf1a9a7bb9b34e6c9f6f9899da480fbd0
---
M src/osmo-bsc/abis_rsl.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/26119/1

diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c
index 0e2ffc6..c3825f6 100644
--- a/src/osmo-bsc/abis_rsl.c
+++ b/src/osmo-bsc/abis_rsl.c
@@ -691,6 +691,12 @@
 		if (bts->type == GSM_BTS_TYPE_BS11)
 			ta <<= 2;
 		msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, ta);
+	} else if ((act_type & 0x06) == 0x00) {
+		/* Note '4)' in section 8.4.1: The Timing Advance element must be
+		 * included if activation type is intra cell channel change. */
+		LOG_LCHAN(lchan, LOGL_NOTICE, "Timing Advance IE shall be present, "
+			  "but the actual value is not known => assuming 0\n");
+		msgb_tv_put(msg, RSL_IE_TIMING_ADVANCE, 0);
 	}
 
 	/* BS/MS Power Control Parameters (if supported by BTS model) */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26119
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iee7ddb4cf1a9a7bb9b34e6c9f6f9899da480fbd0
Gerrit-Change-Number: 26119
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211104/05f3a8df/attachment.htm>


More information about the gerrit-log mailing list