Change in osmo-bts[master]: gsm_ts_release(): Make sure pchan{, is_want} is reset to NONE

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26113 )


Change subject: gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE
......................................................................

gsm_ts_release(): Make sure pchan{,is_want} is reset to NONE

Let's make sure all ts->pchan* related data is reset when we release the
TS. This is important for pchan_is, since in bts-trx upon shutdown
finish the PDCH lchan of a osmo dyn TS is set to
lchan->state=LCHAN_S_NONE, and as a result when the PCU tries to release
it by means of PCUIF act_req later, it may be ignored since the lchan is
already in erased state.

Related: SYS#4971
Change-Id: Ic7c34c0de23101ce094ffd03e00b4d2f6a551152
---
M src/common/gsm_data.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/26113/1

diff --git a/src/common/gsm_data.c b/src/common/gsm_data.c
index 4446958..e5dbf10 100644
--- a/src/common/gsm_data.c
+++ b/src/common/gsm_data.c
@@ -314,4 +314,8 @@
 		struct gsm_lchan *lchan = &ts->lchan[ln];
 		gsm_lchan_release(lchan, LCHAN_REL_ACT_OML);
 	}
+	ts->pchan = GSM_PCHAN_NONE;
+	/* Make sure pchan_is is reset, since PCU act_req to release it will be
+	 * ignored as the lchan will already be released. */
+	ts->dyn.pchan_is = ts->dyn.pchan_want = GSM_PCHAN_NONE;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26113
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic7c34c0de23101ce094ffd03e00b4d2f6a551152
Gerrit-Change-Number: 26113
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211104/f19450a3/attachment.htm>