Change in osmo-pcu[master]: tbf_ul: Document context where tbf_alloc_ul_ccch() is used

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Nov 4 16:24:20 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26061 )

Change subject: tbf_ul: Document context where tbf_alloc_ul_ccch() is used
......................................................................

tbf_ul: Document context where tbf_alloc_ul_ccch() is used

It can be seen that this function properly passes single=true to
tbf_alloc_ul_tbf().

Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20
---
M src/tbf_ul.cpp
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp
index 74b2636..d6936e1 100644
--- a/src/tbf_ul.cpp
+++ b/src/tbf_ul.cpp
@@ -168,7 +168,8 @@
 	return tbf;
 }
 
-/* Alloc a UL TBF to be assigned over CCCH */
+/* Alloc a UL TBF to be assigned over CCCH. Used by request of a "One phase
+ * packet access", where MS requested only 1 PDCH TS (TS 44.018 Table 9.1.8.1). */
 struct gprs_rlcmac_ul_tbf *tbf_alloc_ul_ccch(struct gprs_rlcmac_bts *bts, struct GprsMs *ms)
 {
 	struct gprs_rlcmac_ul_tbf *tbf;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26061
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id83bfd78c88fa9e4fa98268cc726298c276e6f20
Gerrit-Change-Number: 26061
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211104/4cef5938/attachment.htm>


More information about the gerrit-log mailing list