Change in osmo-bts[master]: measurement: make use of gsm48_meas_res_is_valid() macro

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Nov 4 14:41:41 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26105 )


Change subject: measurement: make use of gsm48_meas_res_is_valid() macro
......................................................................

measurement: make use of gsm48_meas_res_is_valid() macro

Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135
Depends: Iae2bd508a08c4b5093d36e514c22218763e11edf
---
M src/common/measurement.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/26105/1

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 4341be7..1a5992b 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -829,7 +829,7 @@
 	/* Parse MS measurement results */
 	if (meas_res == NULL)
 		goto out;
-	if (meas_res->meas_valid != 0) /* 0 = valid */
+	if (!gsm48_meas_res_is_valid(meas_res))
 		goto out;
 
 	/* If the RXQUAL level at the MS drops under a certain threshold
@@ -978,7 +978,7 @@
 	 */
 	if (gh && gh->msg_type == GSM48_MT_RR_MEAS_REP) {
 		mr = (const struct gsm48_meas_res *)gh->data;
-		if (mr->meas_valid == 0) /* 0 = valid */
+		if (gsm48_meas_res_is_valid(mr))
 			dtxu_used = mr->dtx_used;
 	}
 
@@ -991,7 +991,7 @@
 	}
 	lchan_ms_ta_ctrl(lchan, ms_ta, lchan->meas.ms_toa256);
 	lchan_ms_pwr_ctrl(lchan, ms_pwr, ul_rssi, ul_ci_cb);
-	if (mr && mr->meas_valid == 0) { /* 0 = valid */
+	if (mr && gsm48_meas_res_is_valid(mr)) {
 		lchan_bs_pwr_ctrl(lchan, mr);
 		acch_overpower_active_decision(lchan, mr);
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iea6ab7b69defd7ce88c2aa92fcf2b84370a4c135
Gerrit-Change-Number: 26105
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211104/bc497cc0/attachment.htm>


More information about the gerrit-log mailing list