This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
lynxis lazus gerrit-no-reply at lists.osmocom.orglynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 )
Change subject: Make UTRAN encryption algorithms configurable
......................................................................
Patch Set 4:
(5 comments)
https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/gsm_04_08.c@415
PS1, Line 415: is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01,
> This logic > 0x01 is a bit confusion to read. […]
i would like to replace it in a patch after this one
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/gsm_04_08.c@1296
PS4, Line 1296: is_utran ? net->uea_encryption_mask > 0x01 : net->a5_encryption_mask > 0x01,
> it may make sense to have an msc_a_encryption_enabled(msc_a) function, since you do this complex tes […]
i would like to replace it in a patch
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c@172
PS4, Line 172: /* So far just a boolean switch, a future patch might add individual config for UEA1 and UEA2, see OS#4143 */
> This comment is not true anymore.
Done
https://gerrit.osmocom.org/c/osmo-msc/+/22766/4/src/libmsc/msc_vty.c@371
PS4, Line 371: for (i = 0; i < 8; i++) {
> So in the command above we only support UEA0/1/2, but here we go up to 8.
is it a problem? so far we never set it to anything > UEA2 because the vty validates the range and the default is also correct.
https://gerrit.osmocom.org/c/osmo-msc/+/22766/3/src/libmsc/ran_msg_iu.c
File src/libmsc/ran_msg_iu.c:
https://gerrit.osmocom.org/c/osmo-msc/+/22766/3/src/libmsc/ran_msg_iu.c@375
PS3, Line 375: return ranap_new_msg_sec_mod_cmd2(cm->vec->ik, cm->utran.uea_encryption_mask > 0x01 ? cm->vec->ck : NULL,
> You mismatched the arguments. The keystatus needs to be in fron of 0x06. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd
Gerrit-Change-Number: 22766
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Nov 2021 14:41:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211104/a1c04334/attachment.htm>