Change in osmo-bts[master]: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logg...

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/26090 )


Change subject: scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors
......................................................................

scheduler: Fix FACCH msg with l2len==0 going to lower layers and logging errors

Recent commit (see below) changed a check to avoid weird results for msg
which had l2h=NULL, since l2len would return unexpected results there.
However, some code branches like FACCH or TCH seem to be always setting
l2h even if len=0. Hence, we must test either of the 2 scenarios (null
pointer and l2len()).

This commit fixes the following message appearing all the time during
calls:
"""
TCH/F: Prim has odd len=0 != 23
"""

Fixes: fb905b8d235ff2efe6c1cd9fde2b488b311c1cd7
Related: SYS#5676
Related: SYS#4919
Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890
---
M src/common/scheduler.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/26090/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 0388445..ba5c18a 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -869,7 +869,7 @@
 	OSMO_ASSERT(l1sap->oph.msg);
 
 	/* ignore empty frame */
-	if (!l1sap->oph.msg->l2h) {
+	if (!l1sap->oph.msg->l2h || msgb_l2len(l1sap->oph.msg) == 0) {
 		msgb_free(l1sap->oph.msg);
 		return 0;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/26090
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I43152bc8484a35cd004d3303d3a6e6efcdefa890
Gerrit-Change-Number: 26090
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211103/7107a3a7/attachment.htm>