Change in libosmocore[master]: logging: Fix double lock of log_tgt_mutex

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Nov 3 17:02:39 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26089 )

Change subject: logging: Fix double lock of log_tgt_mutex
......................................................................


Patch Set 2:

Thanks, nice catch.  I would rather go for introducing variants that don't hold the mutex.  In the kernel we have __foo() and foo() where the first doesn't grab the lock an the second does.  Not sure if we want to go exactly there, but normally I would expect the published API to take care of any internal locking/mutex as needed....


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6
Gerrit-Change-Number: 26089
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 03 Nov 2021 17:02:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211103/db1b52fc/attachment.htm>


More information about the gerrit-log mailing list