This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26089 to look at the new patch set (#2). Change subject: logging: Fix double lock of log_tgt_mutex ...................................................................... logging: Fix double lock of log_tgt_mutex Recent commit introduced the "blocking-io" param to "log stderr" VTY command, which calls log_target_file_switch_to_{stream,wqueue}. The VTY command already locks the log_tgt_mutex mutex, since it has to access the tgt list. However, the functions mention above also want to lock the same mutex in order to log information. Let's drop the logging to avoid the double lock, and update its documentation to mention it must be called with the lock already held, as documented on other similar functions. The issue can be spotted when running osmo-trx-uhd: """ (gdb) bt #0 0x00007ffff75d7600 in __lll_lock_wait () from /usr/lib/libpthread.so.0 #1 0x00007ffff75d0503 in pthread_mutex_lock () from /usr/lib/libpthread.so.0 #2 0x00007ffff66314fb in log_tgt_mutex_lock_impl () at /git/libosmocore/src/logging.c:130 #3 0x00007ffff6638e74 in log_check_level (subsys=8, subsys at entry=-1, level=level at entry=3) at /git/libosmocore/src/logging.c:1510 #4 0x00007ffff6639c91 in log_target_file_switch_to_wqueue (target=target at entry=0x611000000320) at /git/libosmocore/src/logging.c:1186 #5 0x00007ffff68565d3 in cfg_log_stderr (self=<optimized out>, vty=0x6140000018a0, argc=0, argv=<optimized out>) at /git/libosmocore/src/vty/logging_vty.c:859 #6 0x00007ffff683db3d in cmd_execute_command_strict (vline=0x60b0000dfe80, vty=vty at entry=0x6140000018a0, cmd=cmd at entry=0x0) at /git/libosmocore/src/vty/command.c:2768 7 0x00007ffff683e396 in config_from_file (vty=vty at entry=0x6140000018a0, fp=fp at entry=0x615000036400) at /git/libosmocore/src/vty/command.c:2880 8 0x00007ffff684cedb in vty_read_config_filep (confp=confp at entry=0x615000036400, priv=priv at entry=0x0) at /git/libosmocore/src/vty/vty.c:1529 9 0x00007ffff684ebfc in vty_read_config_file (file_name=0x7fffffffe7d8 "/build/new/conf/osmo-trx-uhd.cfg", priv=0x0) at /git/libosmocore/src/vty/vty.c:1920 10 0x0000555555565270 in main (argc=3, argv=0x7fffffffe3c8) at /git/osmo-trx/Transceiver52M/osmo-trx.cpp:652 """ Debugged by rebuilding libosmocore with "LOG_MTX_DEBUG 1": """ /libosmocore/src/logging.c:1510 [log_check_level] lock /libosmocore/src/logging.c:1522 [log_check_level] unlock /libosmocore/src/vty/logging_vty.c:844 [cfg_log_stderr] lock /libosmocore/src/logging.c:1510 [log_check_level] lock """ Fixes: b72867f0e68c96ca25e1f9929ce92be0a802db6b Related: OS#4311 Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 --- M src/logging.c 1 file changed, 6 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/26089/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb4215fa2f364e28c0bb73fb9975b6c9f50a46f6 Gerrit-Change-Number: 26089 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211103/61234c36/attachment.htm>