This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26043 ) Change subject: pySim-shell: add method to probe for UICC ...................................................................... Patch Set 4: (2 comments) > Patch Set 4: Code-Review+1 > > I'm happy to merge the patch as it is an improvement. Howeve, I think a proper solution is to move all of that detection logic into the various CardProfile etc. classes. > > So the main application code of pySim-shell should really only call one (classmethod?) to perform autodetection aof card profiles, which would then iterate of all subclasses of CardProfile, call their autodetect method, which would do whatever it needs to do, etc. I think I get what you mean. I will move the detection into the profile classes - I put this into WIP until I am done with that. https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py@85 PS4, Line 85: ; > lines don't end with ";" in python Thanks! There is no way to have this in the linter? python does not complain about it, so this goes unnoticed from time to time. https://gerrit.osmocom.org/c/pysim/+/26043/4/pySim-shell.py@109 PS4, Line 109: SIM > word repeated Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I535bef35847140e611d4fa95ed2859ee81cce605 Gerrit-Change-Number: 26043 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 03 Nov 2021 16:25:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211103/d5d63daa/attachment.htm>