This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26055 ) Change subject: commands: do not check SW manually, use send_apdu_checksw() ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py@148 PS2, Line 148: data, sw = self._tp.send_apdu_checksw(pdu) > I would wrap this block into additional try/catch: […] I wasn't sure if the context info about offset and len is useful at all. Its now added again. The line is bit long now. In this particular case it is important that all exception info is represented in one line since the text of the last expectation used as error message in the log of the export command. https://gerrit.osmocom.org/c/pysim/+/26055/2/pySim/commands.py@177 PS2, Line 177: chunk_data, chunk_sw = self._tp.send_apdu_checksw(pdu) > Same here. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce556ac0b7bb21c5c5a27170c32af0152255b79 Gerrit-Change-Number: 26055 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 03 Nov 2021 10:53:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211103/d8973a36/attachment.htm>